Skip to content

Fix compiling to webOS #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cscd98 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiling to webOS #259

cscd98 wants to merge 1 commit into from

Conversation

@cscd98
Copy link

@cscd98 cscd98 commented Dec 6, 2025 •
edited
Loading

Currently fails to build due an issue with dr_mp3

platform/common/dr_libs/dr_mp3.h: In function ‘drmp3_fopen’:
platform/common/dr_libs/dr_mp3.h:3362:17: error: assignment to ‘RFILE *’ from incompatible pointer type ‘FILE *’ [-Wincompatible-pointer-types]
 3362 |         *ppFile = fopen64(pFilePath, pOpenMode);

So switched to MP3 helix (as it is ARM).. 👍

@irixxxx
Copy link
Collaborator

irixxxx commented Dec 8, 2025

Helix sources aren't provided for licensing issues in the picodrive repo.

@cscd98
Copy link
Author

cscd98 commented Dec 8, 2025 •
edited
Loading

Does it need them to compile? I can always look at another fix (it compiles fine atm)

@irixxxx
Copy link
Collaborator

irixxxx commented Dec 8, 2025

No, it compiles in a shard library loader for helix. However, there wouldn't be mp3 sound output without that shard library in place.

@cscd98
Copy link
Author

cscd98 commented Dec 8, 2025

OK i'll see about another fix then 👍

@irixxxx
Copy link
Collaborator

irixxxx commented Dec 8, 2025

I remember having something similar for another lr platform ages ago. Let me try to find it.

@irixxxx
Copy link
Collaborator

irixxxx commented Dec 8, 2025 •
edited
Loading

Look at platform/common/mp3_drmp3.c. In line 13, it checks for libretro VFS usage and cuts out some functions. That would be a good place to add something for this special case.

Defining a wrapper function for fopen64 to use fopen in case it is compiled on webos is probably the simplest method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cscd98 @irixxxx